Skip to content

Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Form Controls#1338

Open
lintsang wants to merge 14 commits into
CodeYourFuture:mainfrom
lintsang:main
Open

Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Form Controls#1338
lintsang wants to merge 14 commits into
CodeYourFuture:mainfrom
lintsang:main

Conversation

@lintsang
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Created a form that fulfilled all the requirements

@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit dd64a9d
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a12dfc40a92860008428a7c
😎 Deploy Preview https://deploy-preview-1338--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@lintsang lintsang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 22, 2026
@Luro91 Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 23, 2026
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you get the SEO score of lighthouse to 100?

Image

Comment thread Form-Controls/index.html
Person name and email</legend>
<div class="form-group">
<label for="fullname">Full Name:</label>
<input type="text" id="fullname" required minlength="2">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on the validation

Comment thread Form-Controls/README.md
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if you should check the checkboxes here or just in the PR

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminder. Sorry I did the same in Sprint 2. I will not touch it in Sprint 3

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants